-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix oms route to retrieve orders #124
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Just to be safe, it's best to wait for the other PR to be ready to they can be deployed together though, since deploying this first would cause problems with the other app, from what I understood here.
Yes, we should deploy b2b-orders-history first! Then, after it is deployed almost everywhere, we deploy this one. |
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
This PR was dropped in favor of: #125 |
What problem is this solving?
https://vtex-dev.atlassian.net/browse/B2BTEAM-1187
On the
/orders-history
page onMy Account
(or on the order page), when clicking on theOrder Again
button, an error page would appear with the message:Sorry, an error occurred while processing your request.
This happens due to the oms API returning
orderGroup = null
when retrieving order info. TheorderGroup
value is used to call the checkout API and create a new cart with same items than previous order.This PR changes the OMS API being used to a new one that actually returns the
orderGroup
. This new API returns mostly the same fields than previous API, and the fields that it does not return, are not used by the B2BSuite apps.The only field that it returns a bit different is the
clientProfileData.email
field. Instead of returning e.g.[email protected]
it returns something like:[email protected]
, so some changes regarding that were necessary on theb2b-orders-history
app (PR)How to test it?
Install fixed versions of
b2b-organizations-graphql
andb2b-orders-history
apps, create an order and use the admin UI to complete it. After that, do the following:Workspace
Screenshots or example usage:
Page with button to click
After clicking the button:
Previously, after clicking the button we would see (notice the "null" on the endpoint path):
Related to / Depends on
vtex-apps/b2b-orders-history#20